Don't link against kokkostools in tests unconditionally #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @masterleinad Imposing kokkostools (monolithic) library requirement only for those Kokkos Tools tests needing it will make it easier for users to run the Kokkos Tools tests on their own platforms. |
vlkale
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
LGTM.
Maybe we put a comment here to developers of Kokkos Tools connectors to only use the monolithic library if it’s needed for a particular test (i.e., we explain the best practice that you conveyed in the description of the PR).
It would be equally fine with me to put this in internal-documents on Kokkos Tools for developers.
crtrott
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests would normally just use environment variables to load the respective tool. In any case, we shouldn't link to
kokkostoolsunconditionally. Tests that set the respective hooks explicitly would not use the environment variableKOKKOS_TOOLS_LIBSand only link againstkokkostoolsthat can either happen explicitly or via another argument tokp_add_executable_and_test.